feat(team_participant): reorganize former members with subheaders in Former tab by Eetwalt · Pull Request #7230 · Liquipedia/Lua-Modules

Eetwalt · 2026-03-10T08:42:24Z

Summary

Resolves #7101. Reorganizes how former staff and former players are displayed by moving them all to the "Former" tab with clear subheaders:

"Players" subheader - Lists former players
"Staff" subheader - Lists former staff members

This provides better organization and clarity compared to displaying former staff in the Staff tab with strikethrough styling.

Key Changes

Former staff members now appear in the Former tab under the "Staff" subheader
Former players appear in the Former tab under the "Players" subheader
Subheaders only display when their section has entries
Staff tab now shows only current/active staff members
Removed strikethrough styling - the tab context makes the status clear

How did you test this change?

dev (tsf2) + devtools

Copilot

Pull request overview

Adjusts TeamParticipants wiki parsing to avoid overwriting an explicitly provided participant type (e.g., former) when the participant also has a staff role, fixing incorrect tab placement in the roster UI.

Changes:

Update staff auto-assignment logic to trigger only when type is the default 'player', preserving explicit type values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lua/wikis/commons/TeamParticipants/Parse/Wiki.lua

mbergen

This has major implications on storage.
https://github.com/Liquipedia/Lua-Modules/blob/main/lua/wikis/commons/TeamParticipants/Repository.lua
will use the type set here to determine the individualprizemoney, and furthermore
https://github.com/Liquipedia/Lua-Modules/blob/main/lua/wikis/commons/Opponent.lua#L566
uses the type to determine whether to store someone as player or staff.

When former staff does not get the correct type here, it will count as player in the mentioned locations and store bad data.
This also affects LPDB/API consumers downstream.

mbergen · 2026-03-10T08:54:36Z

In addition, in my personal opinion, all tabs that are not staff should be reserved for players - that should be the main thing someone is interested in.
(Perhaps the exception to this is CS where the coach is treated as essential part of the roster and would also show on the main tab)

So i'd rather fix the display on the staff tab for former staff, but not move them to another tab.

Eetwalt · 2026-03-10T09:18:19Z

Ah right, major overlook from my part

This has major implications on storage. https://github.com/Liquipedia/Lua-Modules/blob/main/lua/wikis/commons/TeamParticipants/Repository.lua will use the type set here to determine the individualprizemoney, and furthermore https://github.com/Liquipedia/Lua-Modules/blob/main/lua/wikis/commons/Opponent.lua#L566 uses the type to determine whether to store someone as player or staff.

When former staff does not get the correct type here, it will count as player in the mentioned locations and store bad data. This also affects LPDB/API consumers downstream.

Oh, didn't realize 'former' was reserved for players only. In that case yes, this approach doesn't work. Drafting the PR and thinking of alternative solutions.

Also will think if we should keep the former staff in staff tab but have a distinction there with label / strikethrough or something.

Eetwalt · 2026-03-10T12:45:26Z

In addition, in my personal opinion, all tabs that are not staff should be reserved for players - that should be the main thing someone is interested in. (Perhaps the exception to this is CS where the coach is treated as essential part of the roster and would also show on the main tab)

So i'd rather fix the display on the staff tab for former staff, but not move them to another tab.

Discussed with product, decided it would be best to show both Players and Staff under 'Former' but have subheaders above them so there's no confusion.

mbergen · 2026-03-10T12:52:51Z

The implementation currently in this PR seems non-functional, it is still depending on the type being former while it will only be staff, no?

mbergen · 2026-03-10T13:05:42Z

Tbh, ideally we would differentiate between type and status:

type can be player|staff
status can be active|former|substitute (although substitute and former could both happen i guess, so maybe substitute needs to be also separated into a flag?)

Eetwalt · 2026-03-10T14:30:55Z

The implementation currently in this PR seems non-functional, it is still depending on the type being former while it will only be staff, no?

true, had old changes in the dev env as you pointed out. back to the drawing board

…or the ui

mbergen · 2026-03-10T15:06:34Z

lua/wikis/commons/Widget/Participants/Team/Roster.lua

+			if tabTypeEnum == TAB_ENUM.STAFF then
+				return personType == 'staff'
+			elseif tabTypeEnum == TAB_ENUM.FORMER then
+				return player.extradata.isFormer
+			else
+				return PERSON_TYPE_TO_TAB[personType] == tabTypeEnum
+			end


Suggested change

if tabTypeEnum == TAB_ENUM.STAFF then

return personType == 'staff'

elseif tabTypeEnum == TAB_ENUM.FORMER then

return player.extradata.isFormer

else

return PERSON_TYPE_TO_TAB[personType] == tabTypeEnum

end

if player.extradata.isFormer then

return tabTypeEnum == TAB_ENUM.former

else

return PERSON_TYPE_TO_TAB[personType] == tabTypeEnum

end

To avoid former staff from appearing in both former and staff while reducing "duplicate" code

mbergen · 2026-03-10T15:10:10Z

lua/wikis/commons/Widget/Participants/Team/Roster.lua

+		local formerPlayers = Array.filter(players, function(player)
+			return player.extradata.isFormer and player.extradata.type ~= 'staff'
+		end)
+		local formerStaff = Array.filter(players, function(player)
+			return player.extradata.isFormer and player.extradata.type == 'staff'
+		end)


Need to avoid doing this for all tabs, and only do it for the former tab

mbergen · 2026-03-10T15:12:44Z

In general: I still don't think its a great idea to have type and status as one.
Right now, you can mark someone as staff while not having a staff role assigned (for whatever reasons)
With this, you can mark them as former, but that would mean you can't at the same time mark them as staff (unless they are auto-marked as staff due to a role), again leading to implications on storage.

Eetwalt · 2026-03-10T15:16:14Z

In general: I still don't think its a great idea to have type and status as one. Right now, you can mark someone as staff while not having a staff role assigned (for whatever reasons) With this, you can mark them as former, but that would mean you can't at the same time mark them as staff (unless they are auto-marked as staff due to a role), again leading to implications on storage.

Yeah.. I'll discuss this with Rath later. Not happy with it either. Seems like with this non-former staff members don't render so putting it to draft again. Thanks for the patience, seems like we need a bigger rework..

Eetwalt added the c: team_participant label Mar 10, 2026

Eetwalt requested review from a team as code owners March 10, 2026 08:42

Copilot AI review requested due to automatic review settings March 10, 2026 08:42

Eetwalt added the c: team_participant label Mar 10, 2026

Copilot started reviewing on behalf of Eetwalt March 10, 2026 08:42 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

lua/wikis/commons/TeamParticipants/Parse/Wiki.lua Show resolved Hide resolved

mbergen requested changes Mar 10, 2026

View reviewed changes

Eetwalt marked this pull request as draft March 10, 2026 09:18

adjust logic

295b4b9

Eetwalt force-pushed the tp-staff-former branch from 744d5ee to 295b4b9 Compare March 10, 2026 09:44

move all formers to former tab with subheaders

d3c9cd9

Eetwalt changed the title ~~fix(team_participant): preserve explicit type when assigning staff roles~~ feat(team_participant): reorganize former members with subheaders in Former tab Mar 10, 2026

Eetwalt marked this pull request as ready for review March 10, 2026 12:39

Eetwalt requested a review from mbergen March 10, 2026 12:39

This comment was marked as outdated.

Sign in to view

Eetwalt marked this pull request as draft March 10, 2026 14:29

add a extradata field to preserve the type=former for staff members f…

c713722

…or the ui

Eetwalt marked this pull request as ready for review March 10, 2026 14:59

mbergen reviewed Mar 10, 2026

View reviewed changes

remove redundant helper function

c7ea65d

mbergen reviewed Mar 10, 2026

View reviewed changes

Eetwalt marked this pull request as draft March 10, 2026 15:12

Conversation

Eetwalt commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

How did you test this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mbergen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbergen commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eetwalt commented Mar 10, 2026

Uh oh!

Eetwalt commented Mar 10, 2026

Uh oh!

mbergen commented Mar 10, 2026

Uh oh!

mbergen commented Mar 10, 2026

Uh oh!

This comment was marked as outdated.

Eetwalt commented Mar 10, 2026

Uh oh!

mbergen Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

mbergen Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbergen commented Mar 10, 2026

Uh oh!

Eetwalt commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Eetwalt commented Mar 10, 2026 •

edited

Loading

mbergen left a comment •

edited

Loading

mbergen commented Mar 10, 2026 •

edited

Loading

mbergen Mar 10, 2026 •

edited

Loading